process: delay setup of global exception handlers

Since bootstrap/node.js performs the setup synchronously, the process exception handlers do not have to setup so early in the bootstrap process - any fatal errors thrown before user code execution should simply crash the process, and we do not care about any clean up at that point. We don't care about emitting any events if the process crash upon bootstrap either. PR-URL: #26061 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
nodejs · Feb 28, 2019 · b5fe27c · b5fe27c
1 parent 0c4353a
commit b5fe27c
Showing 1 changed file with 14 additions and 18 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -46,24 +46,6 @@ setupTraceCategoryState();
 
 setupProcessObject();
 
-// TODO(joyeecheung): this does not have to done so early, any fatal errors
-// thrown before user code execution should simply crash the process
-// and we do not care about any clean up at that point. We don't care
-// about emitting any events if the process crash upon bootstrap either.
-{
-  const {
-    fatalException,
-    setUncaughtExceptionCaptureCallback,
-    hasUncaughtExceptionCaptureCallback
-  } = NativeModule.require('internal/process/execution');
-
-  process._fatalException = fatalException;
-  process.setUncaughtExceptionCaptureCallback =
-      setUncaughtExceptionCaptureCallback;
-  process.hasUncaughtExceptionCaptureCallback =
-      hasUncaughtExceptionCaptureCallback;
-}
-
 setupGlobalProxy();
 setupBuffer();
 
@@ -303,6 +285,20 @@ Object.defineProperty(process, 'features', {
   }
 });
 
+{
+  const {
+    fatalException,
+    setUncaughtExceptionCaptureCallback,
+    hasUncaughtExceptionCaptureCallback
+  } = NativeModule.require('internal/process/execution');
+
+  process._fatalException = fatalException;
+  process.setUncaughtExceptionCaptureCallback =
+    setUncaughtExceptionCaptureCallback;
+  process.hasUncaughtExceptionCaptureCallback =
+    hasUncaughtExceptionCaptureCallback;
+}
+
 // User-facing NODE_V8_COVERAGE environment variable that writes
 // ScriptCoverage to a specified file.
 if (process.env.NODE_V8_COVERAGE) {