test: fix flaky cluster-disconnect-race

On single core Windows systems, process.send() would cause an EPIPE because of the ordering of the IPC channel disconnect and the process.send(). The test was originally only relevant for non-Windows platforms, so this commit merely skips the test on Windows. Fixes: #4450 PR-URL: #4457 Reviewed-By: Rich Trott <[email protected]>
nodejs · Jan 19, 2016 · c4eeb88 · c4eeb88
1 parent 82cbfcd
commit c4eeb88
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/test/parallel/test-cluster-disconnect-race.js b/test/parallel/test-cluster-disconnect-race.js
@@ -7,6 +7,12 @@ const common = require('../common');
 const assert = require('assert');
 const net = require('net');
 const cluster = require('cluster');
+
+if (common.isWindows) {
+  console.log('1..0 # Skipped: This test does not apply to Windows.');
+  return;
+}
+
 cluster.schedulingPolicy = cluster.SCHED_NONE;
 
 if (cluster.isMaster) {
@@ -19,9 +25,9 @@ if (cluster.isMaster) {
     worker2.on('online', common.mustCall(worker2.disconnect));
   }));
 
-  cluster.on('exit', function(worker, code) {
+  cluster.on('exit', common.mustCall(function(worker, code) {
     assert.strictEqual(code, 0, 'worker exited with error');
-  });
+  }, 2));
 
   return;
 }