test: don't connect to :: (use localhost instead)

If a test does http.listen(0) or net.listen(0), http.listen(0).address().address returns '::'. Some machines will resolve this to localhost, but not all. Every machine should have localhost defined in /etc/hosts (or equivalent), so it should always resolve. Fixes: #7291 PR-URL: #10854 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michal Zasso <[email protected]>
nodejs · Jan 30, 2017 · c60d87b · c60d87b
1 parent 3642f35
commit c60d87b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/test/gc/test-net-timeout.js b/test/gc/test-net-timeout.js
@@ -36,7 +36,7 @@ function getall() {
   if (count >= todo)
     return;
 
-  const req = net.connect(server.address().port, server.address().address);
+  const req = net.connect(server.address().port);
   req.resume();
   req.setTimeout(10, function() {
     req.destroy();

diff --git a/test/parallel/test-http-status-reason-invalid-chars.js b/test/parallel/test-http-status-reason-invalid-chars.js
@@ -3,7 +3,6 @@
 const common = require('../common');
 const assert = require('assert');
 const http = require('http');
-const net = require('net');
 
 function explicit(req, res) {
   assert.throws(() => {
@@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
     implicit(req, res);
   }
 }).listen(0, common.mustCall(() => {
-  const addr = server.address().address;
-  const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
+  const hostname = 'localhost';
   const url = `http://${hostname}:${server.address().port}`;
   let left = 2;
   const check = common.mustCall((res) => {