From cbc140fb6afd250975ef74578ecdf36b37e10369 Mon Sep 17 00:00:00 2001 From: Dylson Valente Neto Date: Fri, 12 Oct 2018 11:15:37 -0700 Subject: [PATCH] test: swap the order arguments are passed to assert Documentation for assertions rule actual values should be passed first followed by the expected value. This commit update the assertions the changed file contains to comply to that rule. Changes also label the assertions. PR-URL: https://github.com/nodejs/node/pull/23580 Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Trivikram Kamat Reviewed-By: Anna Henningsen Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Gireesh Punathil --- test/pummel/test-keep-alive.js | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/test/pummel/test-keep-alive.js b/test/pummel/test-keep-alive.js index 479ec12948175e..b62d731c7b4006 100644 --- a/test/pummel/test-keep-alive.js +++ b/test/pummel/test-keep-alive.js @@ -104,7 +104,20 @@ server.listen(common.PORT, () => { }); process.on('exit', function() { - assert.strictEqual(true, normalReqSec > 50); - assert.strictEqual(true, keepAliveReqSec > 50); - assert.strictEqual(true, normalReqSec < keepAliveReqSec); + assert.strictEqual( + normalReqSec > 50, + true, + `normalReqSec should be greater than 50, but got ${normalReqSec}` + ); + assert.strictEqual( + keepAliveReqSec > 50, + true, + `keepAliveReqSec should be greater than 50, but got ${keepAliveReqSec}` + ); + assert.strictEqual( + normalReqSec < keepAliveReqSec, + true, + 'normalReqSec should be less than keepAliveReqSec, ' + + `but ${normalReqSec} is greater than ${keepAliveReqSec}` + ); });