Skip to content

Commit

Permalink
test: improve test-npm-install
Browse files Browse the repository at this point in the history
Make npm install a dependency that is defined as a relative path, so it
avoids any network interaction.

PR-URL: #5613
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
  • Loading branch information
santigimeno authored and Myles Borins committed Mar 30, 2016
1 parent 7520100 commit d506eea
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion test/parallel/test-npm-install.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ const args = [
'install'
];

const pkgContent = '{}';
const pkgContent = JSON.stringify({
dependencies: {
'package-name': common.fixturesDir + '/packages/main'
}
});

const pkgPath = path.join(common.tmpDir, 'package.json');

Expand All @@ -35,6 +39,9 @@ const proc = spawn(process.execPath, args, {
function handleExit(code, signalCode) {
assert.equal(code, 0, 'npm install should run without an error');
assert.ok(signalCode === null, 'signalCode should be null');
assert.doesNotThrow(function() {
fs.accessSync(common.tmpDir + '/node_modules/package-name');
});
}

proc.on('exit', common.mustCall(handleExit));

0 comments on commit d506eea

Please sign in to comment.