Skip to content

Commit

Permalink
test: fix and improve debug-break-on-uncaught
Browse files Browse the repository at this point in the history
This test runs based on a expectation that the stderr will get the
string 'Debugger listening on port'. But the actual message printed
to stderr has changed to 'Debugger listening on host:port'. So the
the actuals tests did not even start and eventually timeout.

Apart from that, changed `var`s to `let`s or `const`s.

Refs: #10361
PR-URL: #10370
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]
  • Loading branch information
thefourtheye authored and MylesBorins committed Feb 1, 2017
1 parent 80f4a37 commit dbfec29
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions test/debugger/test-debug-break-on-uncaught.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const spawn = require('child_process').spawn;
const common = require('../common');
const debug = require('_debugger');

var scenarios = [];
const scenarios = [];

addScenario('global.js', 2);
addScenario('timeout.js', 2);
Expand All @@ -21,34 +21,33 @@ function addScenario(scriptName, throwsOnLine) {
}

function run() {
var next = scenarios.shift();
const next = scenarios.shift();
if (next) next();
}

function runScenario(scriptName, throwsOnLine, next) {
console.log('**[ %s ]**', scriptName);
var asserted = false;
var port = common.PORT;
let asserted = false;
const port = common.PORT;

var testScript = path.join(
const testScript = path.join(
common.fixturesDir,
'uncaught-exceptions',
scriptName
);

var child = spawn(process.execPath, [ '--debug-brk=' + port, testScript ]);
const child = spawn(process.execPath, [ '--debug-brk=' + port, testScript ]);
child.on('close', function() {
assert(asserted, 'debugger did not pause on exception');
if (next) next();
});

var exceptions = [];
const exceptions = [];

var stderr = '';
let stderr = '';

function stderrListener(data) {
stderr += data;
if (stderr.includes('Debugger listening on port')) {
if (stderr.includes('Debugger listening on ')) {
setTimeout(setupClient.bind(null, runTest), 200);
child.stderr.removeListener('data', stderrListener);
}
Expand All @@ -58,7 +57,7 @@ function runScenario(scriptName, throwsOnLine, next) {
child.stderr.on('data', stderrListener);

function setupClient(callback) {
var client = new debug.Client();
const client = new debug.Client();

client.once('ready', callback.bind(null, client));

Expand All @@ -83,14 +82,14 @@ function runScenario(scriptName, throwsOnLine, next) {
enabled: true
}
},
function(error, result) {
function(error) {
assert.ifError(error);

client.on('exception', function(event) {
exceptions.push(event.body);
});

client.reqContinue(function(error, result) {
client.reqContinue(function(error) {
assert.ifError(error);
setTimeout(assertHasPaused.bind(null, client), 100);
});
Expand Down

0 comments on commit dbfec29

Please sign in to comment.