lib: do not register DOMException in a module

Instead of registering it in a global scope of a native module and expecting that it only gets evaluated when the module is actually compiled and run and will not be evaluated because the module can be cached, directly register the DOMException constructor onto Environment during bootstrap for clarity, since this is a side effect that has to happen during bootstrap. PR-URL: #24708 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 5, 2018 · eab981e · eab981e
1 parent 1743568
commit eab981e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -566,7 +566,9 @@
 
   function setupDOMException() {
     // Registers the constructor with C++.
-    NativeModule.require('internal/domexception');
+    const DOMException = NativeModule.require('internal/domexception');
+    const { registerDOMException } = internalBinding('messaging');
+    registerDOMException(DOMException);
   }
 
   function setupInspector(originalConsole, wrappedConsole) {

diff --git a/lib/internal/domexception.js b/lib/internal/domexception.js
@@ -1,6 +1,5 @@
 'use strict';
 
-const { registerDOMException } = internalBinding('messaging');
 const { ERR_INVALID_THIS } = require('internal/errors').codes;
 
 const internalsMap = new WeakMap();
@@ -85,5 +84,3 @@ for (const [name, codeName, value] of [
 }
 
 module.exports = DOMException;
-
-registerDOMException(DOMException);