test: refactor test-stream-pipe-error-handling

* provide a RegExp for second argument to `assert.throws()` * remove unused function arguments * provide duration of 1 ms for `setTimeout()` calls that do not have a duration PR-URL: #10530 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Jan 24, 2017 · eadab17 · eadab17
1 parent 06f934f
commit eadab17
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/test/parallel/test-stream-pipe-error-handling.js b/test/parallel/test-stream-pipe-error-handling.js
@@ -50,16 +50,16 @@ const Stream = require('stream').Stream;
       assert(removed);
       assert.throws(function() {
         w.emit('error', new Error('fail'));
-      });
-    }));
+      }, /^Error: fail$/);
+    }), 1);
   });
 
   w.on('error', myOnError);
   r.pipe(w);
   w.removeListener('error', myOnError);
   removed = true;
 
-  function myOnError(er) {
+  function myOnError() {
     throw new Error('this should not happen');
   }
 }
@@ -76,10 +76,10 @@ const Stream = require('stream').Stream;
     setTimeout(common.mustCall(function() {
       assert(removed);
       w.emit('error', new Error('fail'));
-    }));
+    }), 1);
   });
 
-  w.on('error', common.mustCall(function(er) {}));
+  w.on('error', common.mustCall(function() {}));
   w._write = function() {};
 
   r.pipe(w);