Skip to content

Commit

Permalink
test: improve assertion in test-inspector.js
Browse files Browse the repository at this point in the history
Remove an unecessary string literal from assert.strictEqual() call in
test-inspector.js. The string literal is printed instead of the value
that causes an error. Removing the string literal allows the value that
caused the error to be printed. This improves the troubleshooting
experience when the test fails due to that assertion.

Backport-PR-URL: #22888
PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
Trott authored and MylesBorins committed Sep 25, 2018
1 parent 0340dd8 commit f2158f3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/sequential/test-inspector.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ function checkBadPath(err) {
}

function checkException(message) {
assert.strictEqual(message.exceptionDetails, undefined,
'An exception occurred during execution');
assert.strictEqual(message.exceptionDetails, undefined);
}

function assertNoUrlsWhileConnected(response) {
Expand Down

0 comments on commit f2158f3

Please sign in to comment.