From f3b5cc0807dbc35bb3742e0ab50a2d5f31704ce9 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Fri, 12 Apr 2019 19:34:08 -0400 Subject: [PATCH] meta: travis: run compilation jobs first even though jobs can run in parallel they start in declaration order * this patch makes "compiles >> no lint" in terms of precedence PR-URL: https://github.com/nodejs/node/pull/27205 Reviewed-By: Richard Lau Reviewed-By: Rich Trott --- .travis.yml | 41 +++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/.travis.yml b/.travis.yml index 7a496a45ab371a..a262ed7f9f4d58 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,26 +9,8 @@ dist: xenial language: cpp jobs: include: - - stage: "Lint and Compile" - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q" - if: type = pull_request - language: node_js - node_js: "node" - script: - - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then - bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; - fi - - - name: "Linter" - language: node_js - node_js: "node" - install: - - pyenv global 2.7.15 - - make lint-py-build || true - script: - - NODE=$(which node) make lint lint-py - - - name: "Compile V8" + - stage: "Compile" + name: "Compile V8" cache: ccache addons: apt: @@ -58,6 +40,7 @@ jobs: - cp out/Release/node /home/travis/.ccache - cp out/Release/cctest /home/travis/.ccache + - pyenv global 2.7.15 - stage: "Tests" name: "Test JS Suites" cache: ccache @@ -85,3 +68,21 @@ jobs: - out/Release/cctest - make -j1 V=1 test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp - python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare addons js-native-api node-api + + - name: "Linter" + language: node_js + node_js: "node" + install: + - pyenv global 2.7.15 + - make lint-py-build || true + script: + - NODE=$(which node) make lint lint-py + + - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q" + if: type = pull_request + language: node_js + node_js: "node" + script: + - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then + bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; + fi