From f4c6f7a5dbfa4b617be475dcbc907ac23304104b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 20 Jun 2019 13:41:00 -0600 Subject: [PATCH] doc: remove "note that" from modules.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/28329 Reviewed-By: Gus Caplan Reviewed-By: Trivikram Kamat Reviewed-By: Tobias Nießen Reviewed-By: Ruben Bridgewater --- doc/api/modules.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/api/modules.md b/doc/api/modules.md index 77369a500fbc10..73771f49af6639 100644 --- a/doc/api/modules.md +++ b/doc/api/modules.md @@ -589,8 +589,8 @@ added: v0.3.0 * {Object} Modules are cached in this object when they are required. By deleting a key -value from this object, the next `require` will reload the module. Note that -this does not apply to [native addons][], for which reloading will result in an +value from this object, the next `require` will reload the module. +This does not apply to [native addons][], for which reloading will result in an error. Adding or replacing entries is also possible. This cache is checked before @@ -675,7 +675,7 @@ changes: * `paths` {string[]} Paths to resolve module location from. If present, these paths are used instead of the default resolution paths, with the exception of [GLOBAL_FOLDERS][] like `$HOME/.node_modules`, which are always - included. Note that each of these paths is used as a starting point for + included. Each of these paths is used as a starting point for the module resolution algorithm, meaning that the `node_modules` hierarchy is checked from this location. * Returns: {string} @@ -728,7 +728,7 @@ added: v0.1.16 The `module.exports` object is created by the `Module` system. Sometimes this is not acceptable; many want their module to be an instance of some class. To do -this, assign the desired export object to `module.exports`. Note that assigning +this, assign the desired export object to `module.exports`. Assigning the desired object to `exports` will simply rebind the local `exports` variable, which is probably not what is desired. @@ -755,7 +755,7 @@ a.on('ready', () => { }); ``` -Note that assignment to `module.exports` must be done immediately. It cannot be +Assignment to `module.exports` must be done immediately. It cannot be done in any callbacks. This does not work: `x.js`: @@ -905,7 +905,7 @@ added: v9.3.0 A list of the names of all modules provided by Node.js. Can be used to verify if a module is maintained by a third party or not. -Note that `module` in this context isn't the same object that's provided +`module` in this context isn't the same object that's provided by the [module wrapper][]. To access it, require the `Module` module: ```js