http: remove redundant code in _deferToConnect

Logic for calling the passed in socket method and/or callback was duplicated. This commit refactors the relevant code to remove the redundancy. PR-URL: #2769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]>
nodejs · Sep 22, 2015 · f68fed2 · f68fed2
1 parent cb971cc
commit f68fed2
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -504,21 +504,23 @@ ClientRequest.prototype._deferToConnect = function(method, arguments_, cb) {
   // in the future (when a socket gets assigned out of the pool and is
   // eventually writable).
   var self = this;
+
+  function callSocketMethod() {
+    if (method)
+      self.socket[method].apply(self.socket, arguments_);
+
+    if (typeof cb === 'function')
+      cb();
+  }
+
   var onSocket = function() {
     if (self.socket.writable) {
-      if (method) {
-        self.socket[method].apply(self.socket, arguments_);
-      }
-      if (cb) { cb(); }
+      callSocketMethod();
     } else {
-      self.socket.once('connect', function() {
-        if (method) {
-          self.socket[method].apply(self.socket, arguments_);
-        }
-        if (cb) { cb(); }
-      });
+      self.socket.once('connect', callSocketMethod);
     }
   };
+
   if (!self.socket) {
     self.once('socket', onSocket);
   } else {