From f98d441461a5b0f4d7aa542c852372efb6d0e4ea Mon Sep 17 00:00:00 2001
From: Daniel Bevenius <daniel.bevenius@gmail.com>
Date: Wed, 19 Sep 2018 14:04:34 +0200
Subject: [PATCH] crypto: extract throwInvalidArgType function
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit extracts the throwing of ERR_INVALID_ARG_TYPE which is done
in identical ways in a few places in cipher.js.

The motivation for this is that I think it improves readability enough to
warrant a commit even though I'm aware that we should avoid commits with
only these sort of refactoring.

PR-URL: https://github.com/nodejs/node/pull/22947
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 lib/internal/crypto/cipher.js | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)

diff --git a/lib/internal/crypto/cipher.js b/lib/internal/crypto/cipher.js
index 52870f8d6bb3ca..d5f6700fa270c1 100644
--- a/lib/internal/crypto/cipher.js
+++ b/lib/internal/crypto/cipher.js
@@ -83,15 +83,19 @@ function createCipherBase(cipher, credential, options, decipher, iv) {
   LazyTransform.call(this, options);
 }
 
+function invalidArrayBufferView(name, value) {
+  return new ERR_INVALID_ARG_TYPE(
+    name,
+    ['string', 'Buffer', 'TypedArray', 'DataView'],
+    value
+  );
+}
+
 function createCipher(cipher, password, options, decipher) {
   validateString(cipher, 'cipher');
   password = toBuf(password);
   if (!isArrayBufferView(password)) {
-    throw new ERR_INVALID_ARG_TYPE(
-      'password',
-      ['string', 'Buffer', 'TypedArray', 'DataView'],
-      password
-    );
+    throw invalidArrayBufferView('password', password);
   }
 
   createCipherBase.call(this, cipher, password, options, decipher);
@@ -101,20 +105,12 @@ function createCipherWithIV(cipher, key, options, decipher, iv) {
   validateString(cipher, 'cipher');
   key = toBuf(key);
   if (!isArrayBufferView(key)) {
-    throw new ERR_INVALID_ARG_TYPE(
-      'key',
-      ['string', 'Buffer', 'TypedArray', 'DataView'],
-      key
-    );
+    throw invalidArrayBufferView('key', key);
   }
 
   iv = toBuf(iv);
   if (iv !== null && !isArrayBufferView(iv)) {
-    throw new ERR_INVALID_ARG_TYPE(
-      'iv',
-      ['string', 'Buffer', 'TypedArray', 'DataView'],
-      iv
-    );
+    throw invalidArrayBufferView('iv', iv);
   }
   createCipherBase.call(this, cipher, key, options, decipher, iv);
 }
@@ -149,11 +145,7 @@ Cipher.prototype.update = function update(data, inputEncoding, outputEncoding) {
   outputEncoding = outputEncoding || encoding;
 
   if (typeof data !== 'string' && !isArrayBufferView(data)) {
-    throw new ERR_INVALID_ARG_TYPE(
-      'data',
-      ['string', 'Buffer', 'TypedArray', 'DataView'],
-      data
-    );
+    throw invalidArrayBufferView('data', data);
   }
 
   const ret = this._handle.update(data, inputEncoding);