From fae0c44147e7d2998969ddd08b2f1b5d9f6cb0c0 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 5 Mar 2018 20:56:49 -0800 Subject: [PATCH] doc: update labels info in onboarding-extras.md Remove information duplicated in onboarding.md. Organize label list for clarity. Remove `deps` label which we don't actually have. PR-URL: https://github.com/nodejs/node/pull/19160 Reviewed-By: Anatoli Papirovski Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca --- doc/onboarding-extras.md | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md index fa2d1ae02d9b60..f07d20e0a86274 100644 --- a/doc/onboarding-extras.md +++ b/doc/onboarding-extras.md @@ -52,17 +52,17 @@ If you cannot find who to cc for a file, `git shortlog -n -s ` may help. ### By Subsystem -We generally sort issues by a concept of "subsystem" so that we know what -part(s) of the codebase it touches. +Subsystems include: -**Subsystems generally are**: +* `lib/*.js` (`assert`, `buffer`, etc.) +* `build` +* `doc` +* `lib / src` +* `test` +* `tools` -* `lib/*.js` -* `doc`, `build`, `tools`, `test`, `deps`, `lib / src` (special), and there may - be others. -* `meta` for anything non-code (process) related - -There may be more than one subsystem valid for any particular issue / PR. +There may be more than one subsystem valid for any particular issue or pull +request. ### General @@ -72,6 +72,7 @@ Please use these when possible / appropriate * `discuss` - Things that need larger discussion * `feature request` - Any issue that requests a new feature (usually not PRs) * `good first issue` - Issues suitable for newcomers to process +* `meta` - For issues whose topic is governance, policies, procedures, etc. --