Skip to content

Commit

Permalink
crypto: remove outdated comment
Browse files Browse the repository at this point in the history
PR-URL: #21511
Fixes: #21488
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
TimothyGu authored and targos committed Jun 25, 2018
1 parent dad7821 commit fefa57a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/node_crypto.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2154,9 +2154,6 @@ void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args) {
if (x509_verify_error == X509_V_OK)
return args.GetReturnValue().SetNull();

// XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe
// in the presence of invalid error codes. Probably academical but something
// to keep in mind if/when node ever grows multi-isolate capabilities.
const char* reason = X509_verify_cert_error_string(x509_verify_error);
const char* code = reason;
#define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break;
Expand Down

0 comments on commit fefa57a

Please sign in to comment.