From fefa57a7a4db80f1015b5e59486a5e1f3051692f Mon Sep 17 00:00:00 2001 From: Timothy Gu Date: Sun, 24 Jun 2018 15:30:17 -0400 Subject: [PATCH] crypto: remove outdated comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/21511 Fixes: https://github.com/nodejs/node/issues/21488 Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig --- src/node_crypto.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/node_crypto.cc b/src/node_crypto.cc index c6dc4c2828044c..73961fd7a5a1d9 100644 --- a/src/node_crypto.cc +++ b/src/node_crypto.cc @@ -2154,9 +2154,6 @@ void SSLWrap::VerifyError(const FunctionCallbackInfo& args) { if (x509_verify_error == X509_V_OK) return args.GetReturnValue().SetNull(); - // XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe - // in the presence of invalid error codes. Probably academical but something - // to keep in mind if/when node ever grows multi-isolate capabilities. const char* reason = X509_verify_cert_error_string(x509_verify_error); const char* code = reason; #define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break;