From ff566276da239a8d2ecc2ebb93719b2242c2b749 Mon Sep 17 00:00:00 2001
From: Philipp Dunkel <pip@pipobscure.com>
Date: Tue, 6 Nov 2018 15:25:35 +0000
Subject: [PATCH] net: remove unreachable check in internalConnect

Checked all call-sites to ensure that this code is truly unreachable.
addressType is always checked before internalConnect is even called.

PR-URL: https://github.com/nodejs/node/pull/24158
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 lib/net.js | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/net.js b/lib/net.js
index 99dc76c8f3baf5..743e9c8bfbc91e 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -830,12 +830,9 @@ function internalConnect(
     if (addressType === 4) {
       localAddress = localAddress || '0.0.0.0';
       err = self._handle.bind(localAddress, localPort);
-    } else if (addressType === 6) {
+    } else { // addressType === 6
       localAddress = localAddress || '::';
       err = self._handle.bind6(localAddress, localPort);
-    } else {
-      self.destroy(new ERR_INVALID_ADDRESS_FAMILY(addressType));
-      return;
     }
     debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
           localAddress, localPort, addressType);