-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.12.0: max-old-space-size can no longer be set via NODE_OPTIONS #16999
Comments
Some tests on Windows 7 x64, > set NODE_OPTIONS="--max-old-space-size=128" && node.06.12.0.exe -v
node.06.12.0.exe: "--max-old-space-size=128" is not supported in NODE_OPTIONS
> set NODE_OPTIONS="--max_old_space_size=128" && node.06.12.0.exe -v
node.06.12.0.exe: "--max_old_space_size=128" is not supported in NODE_OPTIONS
> set NODE_OPTIONS=--max-old-space-size=128 && node.06.12.0.exe -v
node.06.12.0.exe: --max-old-space-size=128 is not allowed in NODE_OPTIONS
> set NODE_OPTIONS=--max_old_space_size=128 && node.06.12.0.exe -v
v6.12.0 |
With the last current: > set NODE_OPTIONS="--max-old-space-size=128" && node -v
node: "--max-old-space-size=128" is not supported in NODE_OPTIONS
> set NODE_OPTIONS="--max_old_space_size=128" && node -v
node: "--max_old_space_size=128" is not supported in NODE_OPTIONS
> set NODE_OPTIONS=--max-old-space-size=128 && node -v
v9.1.0
> set NODE_OPTIONS=--max_old_space_size=128 && node -v
v9.1.0 |
On my OSX x64 (first entry same as in my original comment):
|
6.12.0 is the first 6.x release to include Test with ▶▶▶ nvm use 6.12.0 ~/wrk/com/node 1s (2fdb606dac*)
Now using node v6.12.0 (npm v3.10.10)
▶▶▶ NODE_OPTIONS=--debug-brk node ~/wrk/com/node 1s (2fdb606dac*)
Debugger listening on [::]:5858
> % ▶▶▶ nvm use 6.11.5 ~/wrk/com/node (2fdb606dac*)
Now using node v6.11.5 (npm v3.10.10)
▶▶▶ NODE_OPTIONS=--debug-brk node ~/wrk/com/node 1s (2fdb606dac*)
> % It was added in #12028, you can see the PR in the release post. |
@gibfahn ahhh that explains a lot, and I now see why I was getting confused by this. Our service script uses an env var called
An unfortunate clash of names now that |
Sounds like there was some other stuff going on in your case, but I'll take this as a vote for backporting #14093 to v6.x. |
Oh, but is there still an issue here though...
|
Ah - that'll be where #14093 comes in |
This is only supported in node version 8 |
As of node 6.12.0, the V8 option
--max-old-space-size
is no longer accepted in theNODE_OPTIONS
environment variable and node exits with an error if specified.With 6.11.5, the following works:
With 6.12.0, it fails:
I can't find the release notes for 6.12 in case this was an intentional change, but the docs still list it as a valid option to specify via NODE_OPTIONS: https://nodejs.org/api/cli.html#cli_node_options_options
The text was updated successfully, but these errors were encountered: