-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author ready label not used #20282
Comments
@BridgeAR I've found that the best way to get people engage it is to ping them, it's also worth mentioning during the onboarding process. |
Instead of that I guess I don't really see the point of that label unless it's to distinguish a LGTM from a 'LGTM with comments.' |
@bnoordhuis it also covers making sure the CI passed & stuff like that. It helps to not have to thoroughly check absolutely everything that was posted. The issue it's truly addressing is that not every collaborator lands commits that are not their own, there are only a handful of people that do it regularly so I think at the very least others can make that process easier. |
|
@richardlau Thought we had changed that. Perhaps it should mean that the CI passed because that's honestly half the battle when landing pull requests. Takes me forever to check each failing test to make sure it's a known flake. |
It’s a lot more practical to add the label just after kicking off CI, though. Maybe we can try to change our etiquette to allow editing other collaborator’s “CI: ” comments with something like “(edit: green)” or “(edit: only known flakes)” when somebody checked the results? |
The reasons for adding the label directly after starting the CI were also discussed in the PR that changed the guide. See e.g., #19116 (comment) (there were more comments about this). The name of the label reflects that as well: the author is done and only we have to further agree / see that everything is fine / land the PR. |
It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that. |
It helps immensely to identify PRs that can land (or can land soon) if the
author-ready
label is attached.Since it is not yet used a lot, I kindly ask all @nodejs/collaborators and @nodejs/tsc members to try to use it more frequently as described in our guide.
The text was updated successfully, but these errors were encountered: