-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: handling abandoned PRs #23712
Comments
I think if a collaborator wants to shepherd an abandoned PR, then more power to them. |
A PR that was opened 5 days ago by a code-and-learn participant does not really qualify as "abandoned". People get busy and have other things going on in their lives. It's worth being patient. Generally the way we've handled stalled PRs in the past is to either: (1) ping the author after about a month or more to see if they are still interested in progressing the PR forward, (2) if the PR is in relatively good shape (only style nits remaining) and passes CI, then landing it is fine (we've done this in the past), (3) if the PR still needs work, we label it "stalled" and wait to see if the author or anyone else wishes to pick it up, (4) after several months time, if it becomes obvious that the PR is going no where after it's been stalled for a bit, we can go ahead and close it. |
My opinion: |
It's only been five days. Give it some time. Part of GitHub etiquette is being patient. |
I think that it that specific C&L case the steward jump the gun and didn't give the original author a chance to engage and continue the learning process. The change on it's own is not urgent, and IMHO the main benefit we can get from it, is the engagement with the original author. |
I'm totally behind being patient, IMHO we should give that author the time to follow up on their own. |
P.S. AFAIK We also don't have a policy for dismissing other collaborator's reviews without giving them a chance to respond. |
This conversation seems to have...not quite run its course, but stalled out. I'm going to close it with a |
This came up WRT to #23615 (comment), and specifically WRT to code & learn PRs.
What do we do with abandoned PRs, that is PR that are either incomplete, have outstanding changes requested, or questions left unanswered. Where the author disengaged, or is simply unresponsive for a long time?
And how much time needs to pass before we consider a PR as such.
The text was updated successfully, but these errors were encountered: