Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: patch branches #24467

Closed
devsnek opened this issue Nov 19, 2018 · 10 comments
Closed

meta: patch branches #24467

devsnek opened this issue Nov 19, 2018 · 10 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@devsnek
Copy link
Member

devsnek commented Nov 19, 2018 •
edited
Loading

Non-release branches currently:
@devsnek devsnek added the meta Issues and PRs related to the general management of the project. label Nov 19, 2018
@devsnek devsnek changed the title meta: non-release branches meta: patch branches Nov 19, 2018
@Trott
Copy link
Member

Trott commented Nov 19, 2018

@devsnek What would you like to see done with these? (I'm happy to delete mine.)

@devsnek
Copy link
Member Author

devsnek commented Nov 19, 2018

@Trott I assume they should be deleted.

@jkrems
Copy link
Contributor

jkrems commented Nov 19, 2018

Oops, deleted! Thanks for the ping.

@jasnell
Copy link
Member

jasnell commented Nov 19, 2018

I think add-failing-http2-test-with-writes still has an open PR attached so let's keep that one.

@MylesBorins
Copy link
Contributor

deleted mine

@Trott
Copy link
Member

Trott commented Nov 25, 2018

I think add-failing-http2-test-with-writes still has an open PR attached so let's keep that one.

There are no open PRs authored by @mafintosh at this time.

@Trott
Copy link
Member

Trott commented Nov 25, 2018

I think add-failing-http2-test-with-writes still has an open PR attached so let's keep that one.

There are no open PRs authored by @mafintosh at this time.

That branch was for pull request #19852 which has landed. Seems like it should be safe to unilaterally delete.

@Trott
Copy link
Member

Trott commented Nov 25, 2018

The other remaining branch (add-pump-and-eos) is for #19828 which has also landed. So presumably that branch can be deleted too.

@Trott
Copy link
Member

Trott commented Nov 25, 2018 •
edited
Loading

(Although the PRs are against remote mafintosh/io.js.git and not nodejs/node.git...)

@apapirovski
Copy link
Member

Ok, all those branches are gone so I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@apapirovski @jasnell @MylesBorins @jkrems @Trott @devsnek