deprecated python3 module "imp" used in tools/test.py

[targos]

tools/test.py:32: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses

/cc @cclauss

[cclauss]

Closing as duplicate of #29246

[targos]

I'm reopening because #29246 is closed but the warning is still emitted.

[targos]

The imp module is used here to do a dynamic import:

node/tools/test.py

Lines 795 to 805 in 5783ed7

	try:
	(file, pathname, description) = imp.find_module('testcfg', [ self.path ])
	module = imp.load_module('testcfg', file, pathname, description)
	self.config = module.GetConfiguration(context, self.path)
	if hasattr(self.config, 'additional_flags'):
	self.config.additional_flags += context.node_args
	else:
	self.config.additional_flags = context.node_args
	finally:
	if file:
	file.close()

[cclauss]

The imp module is fully deprecated in all supported Python 3 versions.

[Hellzed]

@targos Try using importlib.find_spec() instead, or importlib.find_loader()

This is from the migration help found here: https://docs.python.org/3/library/imp.html#imp.find_module
And the new module doc: https://docs.python.org/3/library/importlib.html#importlib.util.find_spec

[targos]

@Hellzed Thanks. Note that for the time being, we still have to support Python 2.7 and only importlib.import_module seems to exist in that version: https://docs.python.org/2.7/library/importlib.html

[Hellzed]

@targos There's no one-size-fits-all solution here. We need to to use sys.version_info to define the exact code that loads modules. Do you need to support Python versions > 2.7 and < 3.4 ?

[cclauss]

sys.version_info[:2] in ((2, 7), (3, 5), (3, 6), (3, 7), (3, 8))
https://devguide.python.org/#branchstatus

[cclauss]

@asottile
Do you know someone who would be willing to help out Node.js on this one. I tried but failed.

[asottile]

@asottile
Do you know someone who would be willing to help out Node.js on this one. I tried but failed.

not in particular -- though the solution isn't too difficult. you'd branch on sys.version_info < (3,) and use the importlib machinery in py3+ and imp in python 2.

[cclauss]

OK... Will try again. Thx.

[Hellzed]

I'm on right now, pushing the branch in a moment. Sorry for the delay, busy week.

[Hellzed]

Here's the PR: #30208

[cclauss]

@targos Can we close as fixed in #30208 or are you still seeing this warning?

[targos]

it is fixed