Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 13.2 segfaults running Jest's tests, 13.1 works #30730

Closed
SimenB opened this issue Nov 30, 2019 · 5 comments
Closed

Node 13.2 segfaults running Jest's tests, 13.1 works #30730

SimenB opened this issue Nov 30, 2019 · 5 comments

Comments

@SimenB
Copy link
Member

SimenB commented Nov 30, 2019

  • Version: 13.2.0
  • Platform: Darwin Simens-MacBook-Pro.local 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64 (note that this also happens on CI, which is running some Linux version)
  • Subsystem:

Upgrading to node 13.2 makes one of jest's test fail with a segfault. 13.1 runs fine. I don't get a stack trace, though, just this: [1] 83292 segmentation fault node packages/jest/bin/jest.js.

To reproduce:

$ git clone [email protected]:facebook/jest.git
$ cd jest
$ yarn # or yarn install-no-ts-build to skip TS compilation and save a couple minutes
$ node -v
v13.1.0
$ node packages/jest/bin/jest.js packages/jest-fake-timers/src/__tests__/fakeTimersLolex.test.ts
$ echo $?
0
$ node -v # after nvm use 13.2.0 or something
v13.2.0
$ node packages/jest/bin/jest.js packages/jest-fake-timers/src/__tests__/fakeTimersLolex.test.ts
[1]    83292 segmentation fault  node packages/jest/bin/jest.js

Note that it's this specific test that fails, other tests seem to run fine. I'm currently bisecting, but I'm on a somewhat limited machine, so it's slow going :)

@Trott
Copy link
Member

Trott commented Nov 30, 2019

I'm seeing the same results, but also no segmentation fault when using node compiled from the master branch.

@Trott
Copy link
Member

Trott commented Nov 30, 2019

If I did the bisect correctly, the problem is fixed on master in b7b39e0.

@SimenB
Copy link
Member Author

SimenB commented Nov 30, 2019

Yep, seems like it: jestjs/jest#9244 (comment)

I can also confirm that cherry picking just that commit onto the 13.2.0 tag fixes the issue, so I think we can close this.

Thanks!

@sibelius
Copy link

sibelius commented Jun 8, 2020

is this fixed for node 12?

@Pwndrian
Copy link

@sibelius Seems like this won't be fixed in Node 12, as it is blocked by another issue (that won't be fixed in Node 12, neither): #30681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants