Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate util.log. #4497

Closed
JacksonTian opened this issue Dec 31, 2015 · 7 comments
Closed

deprecate util.log. #4497

JacksonTian opened this issue Dec 31, 2015 · 7 comments
Labels
discuss Issues opened for discussions and feedbacks. util Issues and PRs related to the built-in util module.

Comments

@JacksonTian
Copy link
Contributor

There are more powerful loggers in user land like debug, Maybe we can deprecate it?
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Dec 31, 2015
@jbergstroem
Copy link
Member

I don't quite remember who does those npm runs, but it'd be nice to know what kind of usage we have out there.

@Trott
Copy link
Member

Trott commented Dec 31, 2015

@jbergstroem That would be @ChALkeR I think.

@Fishrock123 Fishrock123 added the discuss Issues opened for discussions and feedbacks. label Jan 4, 2016
@feross
Copy link
Contributor

feross commented Jan 4, 2016

👍

@lprimeroo lprimeroo mentioned this issue Jan 11, 2016
Closed
@ChALkeR
Copy link
Member

ChALkeR commented Jan 13, 2016

@jbergstroem Moderate. About 0.4% of all npm packages, ±.
That includes babel (false positive), irc, node-xml, node-xlsx, etc.
Grep result: https://gist.github.com/ChALkeR/220bc2fe7fcc8dd7a56d.

@ChALkeR
Copy link
Member

ChALkeR commented Jan 13, 2016

+1 to deprecating, but this should be done slowly, I think. Can we start with doc-only deprecation for a whole major release?

@jasnell
Copy link
Member

jasnell commented Apr 12, 2016

+1 to a doc-only deprecation.

@JacksonTian JacksonTian mentioned this issue Apr 12, 2016
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Apr 27, 2016

This was done in v6

@jasnell jasnell closed this as completed Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Issues opened for discussions and feedbacks. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mscdex @feross @jbergstroem @ChALkeR @JacksonTian @jasnell @Trott @Fishrock123