-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import of data url leads to crash #45449
Comments
I'm not able to reproduce on macOS: $ node
Welcome to Node.js v19.0.1.
Type ".help" for more information.
> m=()=>import(`data:text/javascript,`)
[Function: m]
> await m()
[Module: null prototype] { }
> .exit |
Oh wait, I'm actially able to reproduce when I remove the space at the start of the line that assigns $ node
Welcome to Node.js v19.0.1.
Type ".help" for more information.
> m=()=>import(`data:text/javascript,`)
[Function: m]
> await m()
[1] 11470 segmentation fault node Also, FWIW it reproduces without the $ node --no-experimental-repl-await
Welcome to Node.js v19.0.1.
Type ".help" for more information.
> m=()=>import(`data:text/javascript,`)
[Function: m]
> m()
[1] 29893 segmentation fault node --no-experimental-repl-await |
gdb doesn't show much info (debug build)
|
I was able to add a CHECK fail similar to the one a few lines below:
I don't know enough to say but I guess that the script is being garbage collected and the caller held a weak reference and passed the stale id. |
Looks like a duplicate of multiple issues which have been filed over time. possibly be fixed with: #44923 @legendecas |
Appears to be fixed in v21.0.0-nightly202309156a489df73b |
This should be able to be fixed by #48510. |
Version
v19.0.1
Platform
Linux instance-1 5.19.0-0.deb11.2-cloud-arm64 #1 SMP Debian 5.19.11-1~bpo11+1 (2022-10-03) aarch64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Sometimes happens on the first call, sometimes takes a few repeated calls of the statement above.
What is the expected behavior?
No response
What do you see instead?
Crashes here:
Specifically on this line where the value is not found in the map:
node/src/module_wrap.cc
Line 594 in 6ac3a22
Additional information
No response
The text was updated successfully, but these errors were encountered: