-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: make jslint
crashes with out of memory error
#5595
Comments
How about generating a list with find with maxdepth/name *.js, etc and pass that to eslint to avoid traversing? |
Can we use a .eslintignore file? |
@jbergstroem I'm not sure that would work on Windows? IMHO I would rather see this properly fixed as I wouldn't expect |
I think I ran into this too with a directory in |
Fixed by 81fd458. |
tools
I think it may have something to do with the number of files being linted? For example, I have
benchmark/tmp
filled as a result of running thebenchmark/module/module-loader.js
benchmark, which by default generates 50,000 module directories.If I remove the
benchmark/tmp
directory, everything works fine andmake jslint
doesn't crash.Without looking, my guess is that it has to do with
eslint
buffering the linting results for display at the very end. If my hunch is correct, perhaps it should be tweaked so that linting results are streamed instead of buffered?FWIW here is the output from the crash:
The text was updated successfully, but these errors were encountered: