You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lib/punycode.js looks more like the dependency required by the core module url, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.
So I propose the following:
add a deps directory in ./lib directory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend)
update the punycode source file to be the CMD way just like other .js files, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.
The text was updated successfully, but these errors were encountered:
lib/punycode.js
looks more like the dependency required by the core moduleurl
, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.So I propose the following:
./lib
directory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend).js
files, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.The text was updated successfully, but these errors were encountered: