Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode: remove the module system detection from punycode.js #7402

Closed
yorkie opened this issue Jun 24, 2016 · 1 comment
Closed

punycode: remove the module system detection from punycode.js #7402

yorkie opened this issue Jun 24, 2016 · 1 comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@yorkie
Copy link
Contributor

yorkie commented Jun 24, 2016

  • Version: latest
  • Platform: any
  • Subsystem: punycode

lib/punycode.js looks more like the dependency required by the core module url, which is a third party library, and the current source file lib/punycode.js is not that same style with other source files.

So I propose the following:

  • add a deps directory in ./lib directory, so we can put the punycode.js there and load it just like what we are doing except for the source path. (Recommend)
  • update the punycode source file to be the CMD way just like other .js files, this also needs us to add tests and maintainer for this little module even though we are just moving them from the punycode.js project.
@Fishrock123 Fishrock123 added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jun 24, 2016
@Fishrock123
Copy link
Contributor

Duplicate of #7401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

2 participants