Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stream] Standardize a way for writable streams to do work after all data has been consumed. #821

Closed
markstos opened this issue Feb 12, 2015 · 6 comments
Labels
stream Issues and PRs related to the stream subsystem.

Comments

@markstos
Copy link
Contributor

There was a lot of discussion about this pre-fork:

nodejs/node-v0.x-archive#7631
nodejs/node-v0.x-archive#7348

Note that while waiting for an upstreaming fix, @TomFrost implemented a workaround that is published on npmjs.org:

https://www.npmjs.com/package/flushwritable

Perhaps it will be helpful in considering the issue.

@Fishrock123
Copy link
Contributor

https://github.com/iojs/readable-stream may be a better place to discuss this. :)

@Fishrock123 Fishrock123 added the stream Issues and PRs related to the stream subsystem. label Feb 12, 2015
@markstos
Copy link
Contributor Author

@Fishrock123 I opened an issue in the readable-stream queue as you suggested:

nodejs/readable-stream#112

If this is the wrong place for stream issues now, this can be closed.

@vkurchatkin
Copy link
Contributor

I'm +1. Also want _open and _close hooks for all streams

@tellnes
Copy link
Contributor

tellnes commented Feb 12, 2015

+1 from me also.

@vkurchatkin What do you mean by _open and _close. Are you referring to fs streams which does fs.open?

@vkurchatkin
Copy link
Contributor

Yeah, default open, close and destroy implementations which call hooks. Also auto-open, like in fs

@chrisdickinson
Copy link
Contributor

Redirecting conversation to the readable-stream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

No branches or pull requests

5 participants