-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js API cleanup ideas for feedback #9766
Comments
Please see nodejs/api#31 :) |
cc @nodejs/api @nodejs/addon-api |
I think we can simply replace that with a
Can you go into more detail? |
See PR #9767
Thanks @Fishrock123! Fixes are in PR #9767, other changes will be discussed in API/EPS issues. Closing this one, looking forward to getting #9767 reviewed. |
Considering that the
node.h
header is exported for both addons and embedders I see a few things that could be improved:comingnode.h [API] cleanup: remove node_internals.h & extra dependencies from node.h #9767)Cleanup orremove lines to define size_t/ssize_t for UNIX/Windows (node.h#L167-L176).Ideal may be node-specific size typedefs. Any other ideas @tjfontaine?(now part of PR node.h [API] cleanup: remove node_internals.h & extra dependencies from node.h #9767)_Will discuss the remaining ideas elsewhere (related to nodejs/api#31):
Break node.h into the smaller parts such as:API for addonsexternal API for embedder(s)type definitionsOther ideas:Keep the definition ofnode_module
internalC API for Node embeddersI would be happy to submit PRs for whatever ideas may be desired by the community.The text was updated successfully, but these errors were encountered: