From f4b1bf7c2610b85bd388d9ded19d03e2a8a08996 Mon Sep 17 00:00:00 2001 From: gengjiawen Date: Sat, 2 Nov 2019 23:27:48 +0800 Subject: [PATCH 1/3] build: add workaround for WSL Signed-off-by: gengjiawen --- BUILDING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 3a484c42e04d19..c3dbc1a1778e8a 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -146,7 +146,10 @@ platforms. This is true regardless of entries in the table below. systems. Issues that only reproduce on WSL should be reported in the [WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the Windows binary (`node.exe`) in WSL is not recommended. It will not work - without workarounds such as stdio redirection. + without workarounds such as stdio redirection. + If you running into `No module named 'distutils.spawn'` + Error when executing `./configure`, please try `python3 -m pip install setuptools` or `sudo apt install python3-distutils -y`. + For more information, see https://github.com/nodejs/node/issues/30189. 6: Running Node.js on x86 Windows should work and binaries are provided. However, tests in our infrastructure only run on WoW64. From a62ac2838671bc85894f71cc6d5319a8f08af396 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 3 Nov 2019 18:23:53 +0100 Subject: [PATCH 2/3] Fix wording --- BUILDING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index c3dbc1a1778e8a..9ef8528bc823eb 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -147,8 +147,9 @@ platforms. This is true regardless of entries in the table below. [WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the Windows binary (`node.exe`) in WSL is not recommended. It will not work without workarounds such as stdio redirection. - If you running into `No module named 'distutils.spawn'` - Error when executing `./configure`, please try `python3 -m pip install setuptools` or `sudo apt install python3-distutils -y`. + If you run into a `No module named 'distutils.spawn'` error when executing + `./configure`, please try `python3 -m pip install --upgrade setuptools` or + `sudo apt install python3-distutils -y`. For more information, see https://github.com/nodejs/node/issues/30189. 6: Running Node.js on x86 Windows should work and binaries From f9d2fcf9ad1eac4e275674bbba2935a12323762d Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 3 Nov 2019 21:26:02 +0100 Subject: [PATCH 3/3] Moved the workaround to the configure section --- BUILDING.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 9ef8528bc823eb..0df731b099e5c5 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -146,11 +146,7 @@ platforms. This is true regardless of entries in the table below. systems. Issues that only reproduce on WSL should be reported in the [WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the Windows binary (`node.exe`) in WSL is not recommended. It will not work - without workarounds such as stdio redirection. - If you run into a `No module named 'distutils.spawn'` error when executing - `./configure`, please try `python3 -m pip install --upgrade setuptools` or - `sudo apt install python3-distutils -y`. - For more information, see https://github.com/nodejs/node/issues/30189. + without workarounds such as stdio redirection. 6: Running Node.js on x86 Windows should work and binaries are provided. However, tests in our infrastructure only run on WoW64. @@ -286,6 +282,11 @@ $ ./configure $ make -j4 ``` +If you run into a `No module named 'distutils.spawn'` error when executing +`./configure`, please try `python3 -m pip install --upgrade setuptools` or +`sudo apt install python3-distutils -y`. +For more information, see https://github.com/nodejs/node/issues/30189. + The `-j4` option will cause `make` to run 4 simultaneous compilation jobs which may reduce build time. For more information, see the [GNU Make Documentation](https://www.gnu.org/software/make/manual/html_node/Parallel.html).