fs: use default stack size for fsevents pthread on macOS 10.15+ #37722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `SIGBUS` crashes on macOS 10.15 due to FSEvents code attempting to allocate large arrays on the stack. The existing size (`4 * PTHREAD_STACK_MIN` or 32KB) causes a stack overflow when more than ~1000 events are received at once. Fixes: nodejs#37697 Refs: joyent/libuv#964
nodejs-github-bot
added
libuv
gluxon
commented
Mar 12, 2021
|
Changes to libuv need to be made upstream instead of here. |
Ah, that makes sense. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
SIGBUScrashes on macOS 10.15 due to FSEvents code attempting to allocate large arrays on the stack.The existing size (
4 * PTHREAD_STACK_MINor 32KB) causes a stack overflow when more than ~1000 events are received at once. See #37697 (comment) for a more detailed explanation. Removing the manualpthread_attr_setstacksizecall here defaults to a stack size of 512KB.A similar issue appeared in the past when Apple updated their FSEvents code on OS X 10.9 . joyent/libuv#964