From 99f1670b99dfd7bc03141dbb9aa6e4ccdb5ca59e Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Wed, 17 Mar 2021 13:11:05 -0700
Subject: [PATCH] buffer: expose btoa and atob as globals

Signed-off-by: James M Snell <jasnell@gmail.com>
---
 .eslintrc.js                           |  2 ++
 doc/api/buffer.md                      |  4 ++++
 doc/api/globals.md                     | 20 +++++++++++++++++
 lib/internal/bootstrap/node.js         | 31 +++++++++++++++++++++-----
 test/common/index.js                   |  7 ++++++
 test/parallel/test-btoa-atob-global.js |  9 ++++++++
 6 files changed, 67 insertions(+), 6 deletions(-)
 create mode 100644 test/parallel/test-btoa-atob-global.js

diff --git a/.eslintrc.js b/.eslintrc.js
index 7574e1b4b6c7f7..28a31d050a6de1 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -329,5 +329,7 @@ module.exports = {
     TextDecoder: 'readable',
     queueMicrotask: 'readable',
     globalThis: 'readable',
+    btoa: 'readable',
+    atob: 'readable',
   },
 };
diff --git a/doc/api/buffer.md b/doc/api/buffer.md
index f31b8b298b02eb..60c073287baee9 100644
--- a/doc/api/buffer.md
+++ b/doc/api/buffer.md
@@ -3282,6 +3282,8 @@ accessed using `require('buffer')`.
 added: REPLACEME
 -->
 
+> Stability: 3 - Legacy. Use `Buffer.from(data, 'base64')` instead.
+
 * `data` {any} The Base64-encoded input string.
 
 Decodes a string of Base64-encoded data into bytes, and encodes those bytes
@@ -3301,6 +3303,8 @@ and binary data should be performed using `Buffer.from(str, 'base64')` and
 added: REPLACEME
 -->
 
+> Stability: 3 - Legacy. Use `buf.toString('base64')` instead.
+
 * `data` {any} An ASCII (Latin1) string.
 
 Decodes a string into bytes using Latin-1 (ISO-8859), and encodes those bytes
diff --git a/doc/api/globals.md b/doc/api/globals.md
index 6f8c9d3b398c11..831ef06bec6094 100644
--- a/doc/api/globals.md
+++ b/doc/api/globals.md
@@ -146,6 +146,24 @@ This variable may appear to be global but is not. See [`__dirname`][].
 
 This variable may appear to be global but is not. See [`__filename`][].
 
+## `atob(data)`
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 3 - Legacy. Use `Buffer.from(data, 'base64')` instead.
+
+Global alias for [`buffer.atob()`][].
+
+## `btoa(data)`
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 3 - Legacy. Use `buf.toString('base64')` instead.
+
+Global alias for [`buffer.btoa()`][].
+
 ## `clearImmediate(immediateObject)`
 <!-- YAML
 added: v0.9.1
@@ -402,6 +420,8 @@ The object that acts as the namespace for all W3C
 [`URL`]: url.md#url_class_url
 [`__dirname`]: modules.md#modules_dirname
 [`__filename`]: modules.md#modules_filename
+[`buffer.atob()`]: buffer.md#buffer_buffer_atob_data
+[`buffer.btoa()`]: buffer.md#buffer_buffer_btoa_data
 [`clearImmediate`]: timers.md#timers_clearimmediate_immediate
 [`clearInterval`]: timers.md#timers_clearinterval_timeout
 [`clearTimeout`]: timers.md#timers_cleartimeout_timeout
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 260670a20226cb..d8f5c18d12d79b 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -42,6 +42,7 @@ const {
   FunctionPrototypeCall,
   JSONParse,
   ObjectDefineProperty,
+  ObjectDefineProperties,
   ObjectGetPrototypeOf,
   ObjectPreventExtensions,
   ObjectSetPrototypeOf,
@@ -400,7 +401,11 @@ function setupGlobalProxy() {
 }
 
 function setupBuffer() {
-  const { Buffer } = require('buffer');
+  const {
+    Buffer,
+    atob,
+    btoa,
+  } = require('buffer');
   const bufferBinding = internalBinding('buffer');
 
   // Only after this point can C++ use Buffer::New()
@@ -408,11 +413,25 @@ function setupBuffer() {
   delete bufferBinding.setBufferPrototype;
   delete bufferBinding.zeroFill;
 
-  ObjectDefineProperty(global, 'Buffer', {
-    value: Buffer,
-    enumerable: false,
-    writable: true,
-    configurable: true
+  ObjectDefineProperties(global, {
+    'Buffer': {
+      value: Buffer,
+      enumerable: false,
+      writable: true,
+      configurable: true,
+    },
+    'atob': {
+      value: atob,
+      enumerable: false,
+      writable: true,
+      configurable: true,
+    },
+    'btoa': {
+      value: btoa,
+      enumerable: false,
+      writable: true,
+      configurable: true,
+    },
   });
 }
 
diff --git a/test/common/index.js b/test/common/index.js
index 894c8025e71968..03eec756d0a19a 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -38,6 +38,11 @@ const bits = ['arm64', 'mips', 'mipsel', 'ppc64', 's390x', 'x64']
   .includes(process.arch) ? 64 : 32;
 const hasIntl = !!process.config.variables.v8_enable_i18n_support;
 
+const {
+  atob,
+  btoa
+} = require('buffer');
+
 // Some tests assume a umask of 0o022 so set that up front. Tests that need a
 // different umask will set it themselves.
 //
@@ -257,6 +262,8 @@ function platformTimeout(ms) {
 }
 
 let knownGlobals = [
+  atob,
+  btoa,
   clearImmediate,
   clearInterval,
   clearTimeout,
diff --git a/test/parallel/test-btoa-atob-global.js b/test/parallel/test-btoa-atob-global.js
new file mode 100644
index 00000000000000..06a6d3ed28f3f1
--- /dev/null
+++ b/test/parallel/test-btoa-atob-global.js
@@ -0,0 +1,9 @@
+'use strict';
+
+require('../common');
+
+const { strictEqual } = require('assert');
+const buffer = require('buffer');
+
+strictEqual(globalThis.atob, buffer.atob);
+strictEqual(globalThis.btoa, buffer.btoa);