From 8738a7f6a73c39e9979ac5a22f9bf34a5128a522 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Wed, 1 Nov 2023 15:49:12 +0100 Subject: [PATCH] test: relax version check with shared OpenSSL Relax the OpenSSL version check when Node.js is built with the `--shared-openssl` option. Verify only that `process.versions.openssl` is truthy. Fixes: https://github.com/nodejs/node/issues/43078 --- test/parallel/test-process-versions.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js index 31886093df8cc2..03b77f41902347 100644 --- a/test/parallel/test-process-versions.js +++ b/test/parallel/test-process-versions.js @@ -75,13 +75,17 @@ assert.match(process.versions.modules, /^\d+$/); assert.match(process.versions.cjs_module_lexer, commonTemplate); if (common.hasCrypto) { - const versionRegex = common.hasOpenSSL3 ? - // The following also matches a development version of OpenSSL 3.x which - // can be in the format '3.0.0-alpha4-dev'. This can be handy when building - // and linking against the main development branch of OpenSSL. - /^\d+\.\d+\.\d+(?:[-+][a-z0-9]+)*$/ : - /^\d+\.\d+\.\d+[a-z]?(\+quic)?(-fips)?$/; - assert.match(process.versions.openssl, versionRegex); + if (process.config.variables.node_shared_openssl) { + assert.ok(process.versions.openssl); + } else { + const versionRegex = common.hasOpenSSL3 ? + // The following also matches a development version of OpenSSL 3.x which + // can be in the format '3.0.0-alpha4-dev'. This can be handy when + // building and linking against the main development branch of OpenSSL. + /^\d+\.\d+\.\d+(?:[-+][a-z0-9]+)*$/ : + /^\d+\.\d+\.\d+[a-z]?(\+quic)?(-fips)?$/; + assert.match(process.versions.openssl, versionRegex); + } } for (let i = 0; i < expected_keys.length; i++) {