From ec66d4c3e982430e3215416cfa3c46fcbc50b400 Mon Sep 17 00:00:00 2001 From: RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> Date: Tue, 13 Aug 2024 12:26:18 -0400 Subject: [PATCH 1/5] build: update required python version to 3.8 Co-Authored-By: Jim B --- BUILDING.md | 4 ++-- android-configure | 4 +--- configure | 4 +--- configure.py | 2 +- 4 files changed, 5 insertions(+), 9 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index c6d1fafb5de378..c1a50906f13396 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -223,7 +223,7 @@ Consult previous versions of this document for older versions of Node.js: ### Prerequisites -* Python support: the Node.js project supports Python >= 3.6 for building and testing. +* Python support: the Node.js project supports Python >= 3.8 for building and testing. * Memory: at least 8GB of RAM is typically required when compiling with 4 parallel jobs (e.g: `make -j4`) ### Unix and macOS @@ -668,7 +668,7 @@ packages: * [Git for Windows](https://chocolatey.org/packages/git) with the `git` and Unix tools added to the `PATH` -* [Python 3.x](https://chocolatey.org/packages/python) +* [Python 3.8+](https://chocolatey.org/packages/python) * [Visual Studio 2022 Build Tools](https://chocolatey.org/packages/visualstudio2022buildtools) with [Visual C++ workload](https://chocolatey.org/packages/visualstudio2022-workload-vctools) * [NetWide Assembler](https://chocolatey.org/packages/nasm) diff --git a/android-configure b/android-configure index 2731e48d708a4a..49ee97e2596554 100755 --- a/android-configure +++ b/android-configure @@ -8,8 +8,6 @@ command -v python3.11 >/dev/null && exec python3.11 "$0" "$@" command -v python3.10 >/dev/null && exec python3.10 "$0" "$@" command -v python3.9 >/dev/null && exec python3.9 "$0" "$@" command -v python3.8 >/dev/null && exec python3.8 "$0" "$@" -command -v python3.7 >/dev/null && exec python3.7 "$0" "$@" -command -v python3.6 >/dev/null && exec python3.6 "$0" "$@" command -v python3 >/dev/null && exec python3 "$0" "$@" exec python "$0" "$@" ''' "$0" "$@" @@ -23,7 +21,7 @@ except ImportError: from distutils.spawn import find_executable as which print('Node.js android configure: Found Python {}.{}.{}...'.format(*sys.version_info)) -acceptable_pythons = ((3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6)) +acceptable_pythons = ((3, 11), (3, 10), (3, 9), (3, 8)) if sys.version_info[:2] in acceptable_pythons: import android_configure else: diff --git a/configure b/configure index 29ebe882b092cd..56720e8f4c42d9 100755 --- a/configure +++ b/configure @@ -10,8 +10,6 @@ command -v python3.11 >/dev/null && exec python3.11 "$0" "$@" command -v python3.10 >/dev/null && exec python3.10 "$0" "$@" command -v python3.9 >/dev/null && exec python3.9 "$0" "$@" command -v python3.8 >/dev/null && exec python3.8 "$0" "$@" -command -v python3.7 >/dev/null && exec python3.7 "$0" "$@" -command -v python3.6 >/dev/null && exec python3.6 "$0" "$@" command -v python3 >/dev/null && exec python3 "$0" "$@" exec python "$0" "$@" ''' "$0" "$@" @@ -25,7 +23,7 @@ except ImportError: from distutils.spawn import find_executable as which print('Node.js configure: Found Python {}.{}.{}...'.format(*sys.version_info)) -acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6)) +acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8)) if sys.version_info[:2] in acceptable_pythons: import configure else: diff --git a/configure.py b/configure.py index 22ea9d01512c07..434cc0193b35e8 100755 --- a/configure.py +++ b/configure.py @@ -2127,7 +2127,7 @@ def make_bin_override(): if sys.platform == 'win32': raise Exception('make_bin_override should not be called on win32.') # If the system python is not the python we are running (which should be - # python 3), then create a directory with a symlink called `python` to our + # python 3.8+), then create a directory with a symlink called `python` to our # sys.executable. This directory will be prefixed to the PATH, so that # other tools that shell out to `python` will use the appropriate python From 02097e9d23c970666d324b6280a4d3baa806dc25 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Tue, 13 Aug 2024 12:34:42 -0400 Subject: [PATCH 2/5] Update pyproject.toml --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 23edd575d87bf5..84470a8a18b46d 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -7,7 +7,7 @@ exclude = [ "tools/eslint/node_modules", ] line-length = 172 -target-version = "py37" +target-version = "py38" [tool.ruff.lint] select = [ From e6b47ddbe14b213b05cfee2cabde46cf98a4186c Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Tue, 13 Aug 2024 16:09:40 -0400 Subject: [PATCH 3/5] Update BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index c1a50906f13396..5ac47ddbef6d99 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -668,7 +668,7 @@ packages: * [Git for Windows](https://chocolatey.org/packages/git) with the `git` and Unix tools added to the `PATH` -* [Python 3.8+](https://chocolatey.org/packages/python) +* [A supported version of Python][Python versions] * [Visual Studio 2022 Build Tools](https://chocolatey.org/packages/visualstudio2022buildtools) with [Visual C++ workload](https://chocolatey.org/packages/visualstudio2022-workload-vctools) * [NetWide Assembler](https://chocolatey.org/packages/nasm) From 3ff39a386189dd491154e3a86b2cabe7edb4c244 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 14 Aug 2024 07:13:58 -0400 Subject: [PATCH 4/5] Update BUILDING.md Co-authored-by: Christian Clauss --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 5ac47ddbef6d99..c7a51e6c1e4400 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -223,7 +223,7 @@ Consult previous versions of this document for older versions of Node.js: ### Prerequisites -* Python support: the Node.js project supports Python >= 3.8 for building and testing. +* [A supported version of Python][Python versions] for building and testing. * Memory: at least 8GB of RAM is typically required when compiling with 4 parallel jobs (e.g: `make -j4`) ### Unix and macOS From e7f8549aae323dcd19e784ba5708e72654048adb Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 14 Aug 2024 07:14:08 -0400 Subject: [PATCH 5/5] Update BUILDING.md Co-authored-by: Christian Clauss --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index c7a51e6c1e4400..b44e98c08d06a2 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -668,7 +668,7 @@ packages: * [Git for Windows](https://chocolatey.org/packages/git) with the `git` and Unix tools added to the `PATH` -* [A supported version of Python][Python versions] +* [Python 3.x](https://chocolatey.org/packages/python) * [Visual Studio 2022 Build Tools](https://chocolatey.org/packages/visualstudio2022buildtools) with [Visual C++ workload](https://chocolatey.org/packages/visualstudio2022-workload-vctools) * [NetWide Assembler](https://chocolatey.org/packages/nasm)