From 78cd0d06c937e862187f2719be9910bd89ef08b1 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 1 Apr 2016 21:40:21 -0700 Subject: [PATCH] test: fix pummel test failures A handful of tests in `test/pummel` were failing due to undefined variables. The tests in pummel are not run in CI or otherwise exercised regularly so these failures can go unnoticed for a long time. --- test/pummel/test-crypto-dh.js | 5 +++-- test/pummel/test-dtrace-jsstack.js | 2 +- test/pummel/test-net-throttle.js | 12 ++++++------ 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/test/pummel/test-crypto-dh.js b/test/pummel/test-crypto-dh.js index 8d732ed92efd10..6ebfb878be0631 100644 --- a/test/pummel/test-crypto-dh.js +++ b/test/pummel/test-crypto-dh.js @@ -1,6 +1,7 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); +const common = require('../common'); +const assert = require('assert'); +const crypto = require('crypto'); if (!common.hasCrypto) { console.log('1..0 # Skipped: node compiled without OpenSSL.'); diff --git a/test/pummel/test-dtrace-jsstack.js b/test/pummel/test-dtrace-jsstack.js index 2e5c8670553138..f53c950baa32e9 100644 --- a/test/pummel/test-dtrace-jsstack.js +++ b/test/pummel/test-dtrace-jsstack.js @@ -14,7 +14,7 @@ if (os.type() != 'SunOS') { var frames = [ 'stalloogle', 'bagnoogle', 'doogle' ]; var stalloogle = function(str) { - expected = str; + global.expected = str; os.loadavg(); }; diff --git a/test/pummel/test-net-throttle.js b/test/pummel/test-net-throttle.js index e98a6c765a905e..d2f32ec25b6ff2 100644 --- a/test/pummel/test-net-throttle.js +++ b/test/pummel/test-net-throttle.js @@ -1,15 +1,15 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); -var net = require('net'); +const common = require('../common'); +const assert = require('assert'); +const net = require('net'); -var N = 1024 * 1024; -var part_N = N / 3; +const N = 1024 * 1024; +const part_N = N / 3; var chars_recved = 0; var npauses = 0; console.log('build big string'); -body = 'C'.repeat(N); +const body = 'C'.repeat(N); console.log('start server on port ' + common.PORT);