-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website analytics #1268
Comments
@fhemberger Thank you. Can you confirm if those counts are for the specific individual pages or for all of the pages that are in subfolders, e.g. It appears that those numbers may be just for the individual pages, excluding most of the hits in the subfolders. |
@feross Sorry, those were the stats of /docs/, not the API docs. D'oh! Here are the (hopefully) correct ones for the same time period: The problem here is that |
@fhemberger Thanks for the updated stats. I still think something doesn't look right. How can it be that the docs were viewed only a few hundred times? I believe the stats are showing the number of times that the specific page is loaded, not including pages that are nested within. For example, hits to https://nodejs.org/dist/latest-v8.x/ are included, but hits to https://nodejs.org/dist/latest-v8.x/docs/api/ and https://nodejs.org/dist/latest-v8.x/docs/api/buffer.html are not being included. Otherwise, I don't see how the stats could be so low, but please correct me if I'm missing something. |
Actually, it appears that the API docs are missing the Google Analytics script. I see that these pages request the script: https://nodejs.org/en/ But these pages do not: https://nodejs.org/dist/latest-v8.x/docs/api/ @fhemberger Can you also confirm this? |
@feross Yes, I can confirm this. There's only a comment Should have been replaced during the build process: /tools/doc/html.js#L155. Looks like Just found an issue for that, dating back to January: |
That's right, the docs do have support for GA tracking, but it hasn't been enabled yet because I've never been able to find where that |
@fhemberger: yeah, that's the $ENV variable that allows the GA code to be set when building the docs. The problem is that I haven't found where/whom Please feel free to help pinging "someone" ;) |
@nodejs/jenkins-admins to the resuce! |
yep, one of the jenkins admins can indeed do that, is |
@rvagg Thanks, if everything works out, can we re-generate existing docs (at least |
Thanks @rvagg! 👍 |
in theory we could regenerate them all but perhaps we'd be better off doing a |
@rvagg There's an HTML comment |
Which should be replaced with what is produced by nodejs/node/tools/doc/html.js#L171, e.g: <script src="assets/dnt_helper.js"></script>
<script>
if (!_dntEnabled()) {
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;
i[r]=i[r]||function(){(i[r].q=i[r].q||[]).push(arguments)},
i[r].l=1*new Date();a=s.createElement(o),m=s.getElementsByTagName(o)[0];
a.async=1;a.src=g;m.parentNode.insertBefore(a,m)})(window,document,
'script','//www.google-analytics.com/analytics.js','ga');
ga('create', 'UA-67020396-1', 'auto');
ga('send', 'pageview');
}
</script> |
The latest nightly (generated today) still shows a @rvagg Looks like this still might not be working? |
OK, so it's because we run Inserting a |
https://nodejs.org/download/nightly/v9.0.0-nightly2017062132c7f114c5/docs/api/ bingo nodejs/node#13861 8.1.2 will probably be the first opportunity to test this on an actual release but as it's exactly the same process I don't imagine there'll be any problem. This issue can either be closed now or you could wait to confirm. |
@rvagg Awesome! One question: will analytics be added to previous release docs once 8.1.2 is released? Or will it only be on 8.1.2 and later docs? @fhemberger I'm still curious about the actual traffic numbers to Node.js docs, but I guess we have to wait a while to collect some data now :) Can you add me to the Google Analytics account (read-only access) so I can poke around? My email address is |
I don't think I have access anymore, it was linked to my linuxfoundation.org Google Account which I don't have anymore :( Maybe @ZibbyKeaton can help. |
I do not have sufficient permissions to do that. Do you know anyone else that might @mikeal ? |
Ok, looks like I have sufficient permissions. Just wanted to make sure it's okay, will add him later. |
@mikeal Yes, you're still registered with your linuxfoundation.org account. Do you want me to change that? |
Closing this issue for now, feel free to reopen if there are further questions regarding analytics. |
How popular are the Node.js docs? I'm curious about the total monthly page views, unique visitors, and time spent on site for everything in
/docs/api
.It would also be interesting to know how many page views the website as a whole receives.
The text was updated successfully, but these errors were encountered: