Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests failing in node 21 #2931

Closed
KhafraDev opened this issue Mar 7, 2024 · 3 comments
Closed

tests failing in node 21 #2931

KhafraDev opened this issue Mar 7, 2024 · 3 comments
Labels
bug Something isn't working Tests Changes related to the unit tests

Comments

@KhafraDev
Copy link
Member

https://github.com/nodejs/undici/actions/runs/8179418041/job/22365444520
https://github.com/nodejs/undici/actions/runs/8179418041/job/22365444256
@KhafraDev KhafraDev added the bug Something isn't working label Mar 7, 2024
@Uzlopak
Copy link
Contributor

Uzlopak commented Mar 7, 2024

after is for some reason broken in node v. 21.7.0

We could rewrite it to not use after.... but i doubt that this is the way to got

@Uzlopak Uzlopak mentioned this issue Mar 7, 2024
Closed
@metcoder95 metcoder95 added the Tests Changes related to the unit tests label Mar 7, 2024
@metcoder95
Copy link
Member

Waiting for: nodejs/node#51998

@Uzlopak
Copy link
Contributor

Uzlopak commented Mar 9, 2024

v21.7.1 got released.

@Uzlopak Uzlopak closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Tests Changes related to the unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Uzlopak @metcoder95 @KhafraDev