Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing the replace call from "exceptionMatch" substring #664

Closed
hasezoey opened this issue Jun 15, 2022 · 3 comments
Closed

Consider removing the replace call from "exceptionMatch" substring #664

hasezoey opened this issue Jun 15, 2022 · 3 comments
Labels
breaking This PR is a breaking change | This Issue to fix would be a breaking change enhancement released on @beta released Pull Request released | Issue is fixed
Milestone
9.0

Comments

@hasezoey
Copy link
Member

Currently there is a .replace call on the substring, which is there for backwards compat, but could be considered to be removed in the next major version.

https://github.com/nodkz/mongodb-memory-server/blob/9546cf9db5ed4ad0c37f5979d832b242ad1d390e/packages/mongodb-memory-server-core/src/util/MongoInstance.ts#L590
@hasezoey hasezoey added enhancement breaking This PR is a breaking change | This Issue to fix would be a breaking change labels Jun 15, 2022
@hasezoey hasezoey added this to the 9.0 milestone Jun 15, 2022
hasezoey added a commit that referenced this issue Aug 17, 2022
@hasezoey
feat(MongoInstance::checkErrorInLine): dont remove ", terminating" fr…
793aa0d 
…om error

fixes #664

BREAKING CHANGE:
potentially breaking change not removing ", terminating" from error
@hasezoey
Copy link
Member Author

hasezoey commented May 8, 2023

done with 793aa0d

@hasezoey hasezoey closed this as completed May 8, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 9.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hasezoey
Copy link
Member Author

hasezoey commented Oct 6, 2023

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Manual message because semantic-release hit the limit

@hasezoey hasezoey added the released Pull Request released | Issue is fixed label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This PR is a breaking change | This Issue to fix would be a breaking change enhancement released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Milestone
9.0
Development

No branches or pull requests
1 participant
@hasezoey