Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct test for mutually exclusive feature flags #1085

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Apr 3, 2023

Related issue(s)

Resolves #1084

Description

Summary of changes

I've updated the checks to match the feature flags which are in use.

I've also removed the default feature flag for the nargo package. This should be set in the nargo_cli crate (and by any direct consumers of nargo)

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

jfecher
jfecher previously approved these changes Apr 3, 2023
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench added this pull request to the merge queue Apr 3, 2023
@phated phated removed this pull request from the merge queue due to a manual request Apr 3, 2023
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the default?

crates/nargo/Cargo.toml Outdated Show resolved Hide resolved
@TomAFrench
Copy link
Member Author

@phated and I came to the conclusion that we should be defining the backends in the nargo_cli crate and then passing this through into nargo. This is necessary to avoid conflicting backend feature flags when we're using nargo as a dependency of noir-wasm (as this would rely on the wasm backend)

@TomAFrench TomAFrench added this pull request to the merge queue Apr 3, 2023
Merged via the queue into master with commit eb5c917 Apr 3, 2023
@TomAFrench TomAFrench deleted the feature-flag-fixes branch April 3, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for enabling multiple backends is broken
3 participants