Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa): set correct predecessors of IF join #1171

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix(ssa): set correct predecessors of IF join #1171

merged 1 commit into from
Apr 18, 2023

Conversation

guipublic
Copy link
Contributor

Related issue(s)

Resolves #1169

Description

Summary of changes

Set the proper predecessor block for IF joins

Test additions / changes

Test case added in regression integration test

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

@guipublic guipublic changed the title fix predecessors of IF join fix: set correct predecessors of IF join Apr 18, 2023
@guipublic guipublic changed the title fix: set correct predecessors of IF join fix(1169): set correct predecessors of IF join Apr 18, 2023
@kevaundray kevaundray changed the title fix(1169): set correct predecessors of IF join fix(ssa): set correct predecessors of IF join Apr 18, 2023
@kevaundray kevaundray added this pull request to the merge queue Apr 18, 2023
Merged via the queue into master with commit 7628ed6 Apr 18, 2023
@kevaundray kevaundray deleted the gd/issue_1169 branch April 18, 2023 18:02
@kevaundray kevaundray mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No element at index
2 participants
@guipublic @kevaundray