Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): update noir to build wasm with a nix flake file #1208

Merged
merged 175 commits into from
Jun 16, 2023
Merged

feat(ci): update noir to build wasm with a nix flake file #1208

merged 175 commits into from
Jun 16, 2023

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Apr 24, 2023 •
edited
Loading

Related issue(s)

Resolves #1543, #1545

Description

Summary of changes

Sets up noir wasm build to be done via nix flake

Dependency additions / changes

None

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@jonybur jonybur changed the title feat: add wasm testing (WIP) feat(ci): add wasm testing (WIP) Apr 26, 2023
@jonybur jonybur changed the title feat(ci): add wasm testing (WIP) feat(ci): add noir_wasm testing Apr 26, 2023
@jonybur jonybur changed the title feat(ci): add noir_wasm testing feat(ci): add noir_wasm testing to PR Apr 26, 2023
@jonybur jonybur marked this pull request as ready for review April 26, 2023 13:47
phated
phated reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sweet. Had a couple of questions

.github/workflows/wasm.yml Outdated Show resolved Hide resolved
.github/workflows/wasm.yml Outdated Show resolved Hide resolved
phated
phated reviewed Jun 15, 2023
View reviewed changes
.github/workflows/wasm.yml Outdated Show resolved Hide resolved
phated
phated reviewed Jun 15, 2023
View reviewed changes
.github/workflows/wasm.yml Outdated Show resolved Hide resolved
phated
phated reviewed Jun 15, 2023
View reviewed changes
.github/workflows/wasm.yml Outdated Show resolved Hide resolved
phated
phated reviewed Jun 15, 2023
View reviewed changes
crates/wasm/README.md Outdated Show resolved Hide resolved
phated
phated reviewed Jun 15, 2023
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
phated
phated reviewed Jun 15, 2023
View reviewed changes
crates/wasm/postBuild.sh Outdated Show resolved Hide resolved
@jonybur jonybur marked this pull request as draft June 15, 2023 22:40
jonybur and others added 2 commits June 15, 2023 23:41
@jonybur @phated
Update crates/wasm/README.md
75c5c27 
Co-authored-by: Blaine Bublitz <[email protected]>
@jonybur @phated
Update .github/workflows/wasm.yml
9a66798 
Co-authored-by: Blaine Bublitz <[email protected]>
phated
phated reviewed Jun 16, 2023
View reviewed changes
crates/wasm/README.md Outdated Show resolved Hide resolved
phated
phated reviewed Jun 16, 2023
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@jonybur jonybur marked this pull request as ready for review June 16, 2023 21:10
@phated phated added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit 2209369 Jun 16, 2023
@phated phated deleted the jb/noir-wasm-workflow branch June 16, 2023 22:25
@kevaundray kevaundray mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobyhallx kobyhallx kobyhallx left review comments

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update noir to build wasm with a nix flake file
4 participants
@jonybur @kobyhallx @Savio-Sou @phated