Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nargo): replace aztec_backend with acvm-backend-barretenberg #1226

Merged
merged 10 commits into from
May 1, 2023
Merged

chore(nargo): replace aztec_backend with acvm-backend-barretenberg #1226

merged 10 commits into from
May 1, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Apr 25, 2023 •
edited
Loading

Related issue(s)

Description

Summary of changes

This PR updates the backend commit to use the new acvm-backend-barretenberg package rather than the two separate aztec_backend packages.

Dependency additions / changes

Updated backend commit to noir-lang/acvm-backend-barretenberg@ba1d0d6

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

BEGIN_COMMIT_OVERRIDE
chore(nargo): replace aztec_backend with acvm-backend-barretenberg (#1226)

fix: fix linear_eval is no 0 serialisation issue (#1226)
END_COMMIT_OVERRIDE

@TomAFrench TomAFrench changed the title chore: replace aztec_backend with acvm-backend-barretenberg chore(nargo): replace aztec_backend with acvm-backend-barretenberg Apr 25, 2023
phated
phated suggested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold this for acvm 10 and the CRS work

@TomAFrench
Copy link
Member Author

Why so? aztec_backend has gone through some pretty sizable reshaping recently and I think it would be good to get this in prior to us updating the interface.

@TomAFrench
Copy link
Member Author

I'd be happy to push out 0.10.0 sooner rather than later and bundle that with this update of the backend as there's various changes in this repo which are blocked on that release. CRS updates might be best to wait for another release however.

@vezenovm
Copy link
Contributor

I'd be happy to push out 0.10.0 sooner rather than later and bundle that with this update of the backend as there's various changes in this repo which are blocked on that release. CRS updates might be best to wait for another release however.

I'd be good to push out 0.10.0 and hold off on any interface changes for another release. Updating this repo to reflect 0.10.0 would also make some of my work easier

@TomAFrench
Copy link
Member Author

Updating this PR to target the ACVM 0.10.0 branch

@TomAFrench
Merge branch 'master' into bump-backend
57ae056 
* master:
  chore: address clippy warnings (#1239)
  chore(ssa refactor): Implement function calls (#1235)
  chore(ssa refactor): Implement mutable and immutable variables (#1234)
  chore(ssa refactor): Fix recursive printing of blocks (#1230)
  feat(noir): added assert keyword (#1227)
  chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225)
  feat(noir): added `distinct` keyword (#1219)
@TomAFrench
chore: move ComputeMerkleRoot to same match arm as `HashToField128S…
24b680f 
…ecurity`
@TomAFrench
chore: bump backend commit
d79b7f3
@TomAFrench
feat: update stdlib to use new merkle black box function
c64992a
@TomAFrench
fix: bump commit of barretenberg to match acvm-backend-barretenberg
5703482
@TomAFrench
feat: update merkle_insert to use new compute_merkle_root function
0171a46
@TomAFrench
chore: update to use ACVM 0.10.3
75b9dc9
@kevaundray kevaundray mentioned this pull request Apr 28, 2023
Closed
6 tasks
@TomAFrench
Copy link
Member Author

TomAFrench commented Apr 28, 2023 •
edited
Loading

Ah, we'll probably want to hold off on this until 0.5.0 is out.

@kevaundray
Copy link
Contributor

Ah, we'll probably want to hold off on this until 0.5.0 is out.

Would noir-lang/acvm-backend-barretenberg@7f42535 also need to wait for 0.5 ?

@TomAFrench
Copy link
Member Author

Yeah, we can release that in a 0.5.1 immediately after.

@kevaundray
Copy link
Contributor

Yeah, we can release that in a 0.5.1 immediately after.

Okay, seems unavoidable since it was put in after the aztec_backend changes and we don't currently have a good way to patch 0.4

@kevaundray kevaundray mentioned this pull request Apr 28, 2023
Closed
1 task
@kevaundray
Copy link
Contributor

Removed the "Resolves issue" from description, these should be checked indivually just incase the issue is not fixed

@kevaundray
Copy link
Contributor

I think we should hold this for acvm 10 and the CRS work

Lets push this out and push the CRS work out in another release

@kevaundray kevaundray requested a review from vezenovm May 1, 2023 10:36
vezenovm
vezenovm approved these changes May 1, 2023
View reviewed changes
noir_stdlib/src/merkle.nr Show resolved Hide resolved
@kevaundray kevaundray mentioned this pull request May 1, 2023
Merged
6 tasks
@TomAFrench TomAFrench added this pull request to the merge queue May 1, 2023
Merged via the queue into master with commit 41d96ae May 1, 2023
@TomAFrench TomAFrench deleted the bump-backend branch May 1, 2023 15:25
@TomAFrench TomAFrench mentioned this pull request May 1, 2023
Merged
TomAFrench added a commit that referenced this pull request May 2, 2023
@TomAFrench
chore(nargo): replace aztec_backend with acvm-backend-barretenberg (
3323e6d 
#1226)

* chore: replace `aztec_backend` with `acvm-backend-barretenberg`

* feat: update to ACVM 0.10.0

* chore: move `ComputeMerkleRoot` to same match arm as `HashToField128Security`

* chore: bump backend commit

* feat: update stdlib to use new merkle black box function

* fix: bump commit of barretenberg to match acvm-backend-barretenberg

* feat: update `merkle_insert` to use new `compute_merkle_root` function

* chore: update to use ACVM 0.10.3

* chore: bump backend commit
TomAFrench added a commit that referenced this pull request May 2, 2023
@TomAFrench
Merge branch 'master' into joss/smt
65cc770 
* master: (63 commits)
  feat(nargo): Remove usage of `CompiledProgram` in CLI code and use separate ABI/bytecode (#1269)
  feat: add integration tests for bitshift operators (#1272)
  chore: Replace explicit if-elses with `FieldElement::from<bool>()` for boolean fields (#1266)
  chore(noir): constrain expr; -> assert(expr); (#1276)
  chore: fix clippy warning (#1270)
  chore(ssa refactor): Add all remaining doc comments to ssa generation pass (#1256)
  chore(noir): Release 0.5.1 (#1264)
  fix: Add Poseidon examples into integration tests (#1257)
  chore(nargo): replace `aztec_backend` with `acvm-backend-barretenberg` (#1226)
  chore(noir): Release 0.5.0 (#1202)
  chore(ci): Utilize new workflow to build binaries (#1250)
  chore(ssa refactor): Fix loading from mutable parameters (#1248)
  fix(wasm): add std after dependencies (#1245)
  chore(ssa refactor): Fix no returns & duplicate main (#1243)
  chore(ssa refactor): Implement intrinsics (#1241)
  chore(ssa refactor): Implement first-class functions (#1238)
  chore: address clippy warnings (#1239)
  chore(ssa refactor): Implement function calls (#1235)
  chore(ssa refactor): Implement mutable and immutable variables (#1234)
  chore(ssa refactor): Fix recursive printing of blocks (#1230)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

@phated phated phated approved these changes

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomAFrench @vezenovm @kevaundray @phated