Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for constrain #1228

Closed
1 task done
kevaundray opened this issue Apr 26, 2023 · 4 comments · Fixed by #1286
Closed
1 task done

Add deprecation warning for constrain #1228

kevaundray opened this issue Apr 26, 2023 · 4 comments · Fixed by #1286
Assignees
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

As of #1227 we are deprecating constrain for assert. Since we don't want to break all existing Noir programs, we will for now just add a deprecation warning whenever constrain is used to tell folks to use assert.

Proposed solution

Add deprecation warning

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@kevaundray kevaundray added the enhancement New feature or request label Apr 26, 2023
@joss-aztec
Copy link
Contributor

I'm guessing the scope of this task includes removing all stdlib usages of constrain, since otherwise the user has to tolerate a ton of warnings.

@TomAFrench
Copy link
Member

Linking #1251 to this issue as as Joss says, we need to address it first.

@joss-aztec
Copy link
Contributor

Ah, we're in a bit of a tangle. They won't be able to fix the tests without fixing stldlib. Should I back my stdlib changes out, and leave that to the scope of #1275?

@joss-aztec
Copy link
Contributor

Oh actually that's not true, because they won't encounter the depreciation warning because it's not merged yet 😅. It's just my PR that's blocked since the tests won't pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
3 participants