-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable dynamic arrays #1271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall -- can you make a separate project for dynamic arrays since we may want to add regression tests for it and it may start to become large
could you clarify what is the project you mean? |
Just another noir example project, so instead of |
Oh just realized from this PR that using "[X]" instead of "[x]" for checkboxes won't trigger the |
Related issue(s)
Resolves #1011
Description
Summary of changes
Enable dynamic arrays in noir. It was disabled because of a bug in the backend which is finally solved.
Test additions / changes
The integration test is uncomment and can be verified successfully.
Checklist
cargo fmt
with default settings.Documentation needs
Comptime types are not required anymore when indexing an array.
Additional context
Note that this does not use the UP RAM lookup table. It will be added in another PR.
BEGIN_COMMIT_OVERRIDE
feat: Enable dynamic arrays (#1271)
END_COMMIT_OVERRIDE