Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssa refactor): Implement dominator tree #1278

Merged
merged 12 commits into from
May 3, 2023
Merged

feat(ssa refactor): Implement dominator tree #1278

merged 12 commits into from
May 3, 2023

Conversation

joss-aztec
Copy link
Contributor

Related issue(s)

Resolves #1116

Description

Summary of changes

  • Add PostOrder for calculating the post-order of a function reachable blocks
  • Adds DominatorTree for querying one block's dominance over another
  • Make finished Ssa's function collection accessible so that the FunctionBuilder can be used in unit tests

Dependency additions / changes

Test additions / changes

Unit test for both of the above

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@joss-aztec joss-aztec mentioned this pull request May 2, 2023
Closed
6 tasks
jfecher
jfecher reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor item

crates/noirc_evaluator/src/ssa_refactor/ir/dom.rs Outdated Show resolved Hide resolved
@kevaundray kevaundray requested a review from jfecher May 2, 2023 18:33
jfecher
jfecher approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench changed the title feat(ssa refactor): dominator tree (retake) feat(ssa refactor): Implement dominator tree May 3, 2023
@joss-aztec joss-aztec added this pull request to the merge queue May 3, 2023
Merged via the queue into master with commit 144ebf5 May 3, 2023
@joss-aztec joss-aztec deleted the joss/domtree2 branch May 3, 2023 08:24
This was referenced May 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dominator Tree
2 participants
@joss-aztec @jfecher