Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix struct or tuple field assignment failing with generics #1317

Merged
merged 1 commit into from
May 8, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented May 8, 2023

Related issue(s)

Resolves #1315

Description

Summary of changes

Fixes an issue where we forgot to call .follow_bindings() before matching on a type to see if it was a struct, tuple, or neither. This led to the issue described in #1315 where the compiler did not see the type as a struct and thus thought there was no field of the given name.

Dependency additions / changes

None

Test additions / changes

None

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray enabled auto-merge May 8, 2023 17:09
@kevaundray kevaundray added this pull request to the merge queue May 8, 2023
Merged via the queue into master with commit d872890 May 8, 2023
@kevaundray kevaundray deleted the jf/fix-generics branch May 8, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: nested struct member access
2 participants