Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: update to ACVM 0.13.0 #1393

Merged
merged 33 commits into from
Jun 1, 2023
Merged

chore!: update to ACVM 0.13.0 #1393

merged 33 commits into from
Jun 1, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem

Updates to track ACVM 0.13.0

Summary*

This PR tracks the changes made in noir-lang/acvm-backend-barretenberg#205.

Getting a strange error where rust can't find acvm-backend-barretenberg for some reason.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

  • compute_merkle_root is no longer implemented as a black box function (but still exists in stdlib)

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

phated and others added 16 commits May 15, 2023 11:46
@phated
chore!: Update to ACVM 0.12.0
4f139ee
@sirasistant @phated
feat: adapted to heterogeneous bb calls
133e261
@sirasistant @phated
chore: update cargo tomls
57d1cbf
@sirasistant @phated
test: re enabled sort test
9375d3b
@sirasistant @phated
fix: improve variable resolution
2132c0a
@sirasistant @phated
feat: use dummy constructor for bb call
d22be54
@phated
updates for latest
b71f690
@phated
feat!: Move WitnessMap type into ACVM to avoid leaking BTreeMap type
e1f5b61
@TomAFrench
Merge branch 'master' into phated/acvm-0.12.0
fc9df35 
* master:
  fix: Fix modulo operator for comptime values (#1361)
  chore: clarify that `verify_signature` takes a hashed message (#1365)
  feat: pass in closure to `Driver` to signal backend opcode support (#1349)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
@phated
feat(nargo): Consume CommonReferenceString functions & manage caching (…
140587b 
…#1348)
@TomAFrench
Merge branch 'master' into phated/acvm-0.12.0
3316fb9
@phated
switch to published acvm and backend
56a237d
@phated
fix compilation issue
6a2330c
@vezenovm @phated @TomAFrench
chore: Remove usage of acvm::default_is_opcode_supported (#1366)
8ca4ec6 
Co-authored-by: Blaine Bublitz <[email protected]>
Co-authored-by: Tom French <[email protected]>
@phated
add issue numbers to TODOs
60ba165
@TomAFrench
chore: update to ACVM 0.13.0
29c6f66
Base automatically changed from phated/acvm-0.12.0 to master May 24, 2023 12:10
@vezenovm vezenovm mentioned this pull request May 31, 2023
Merged
2 tasks
@vezenovm vezenovm mentioned this pull request May 31, 2023
Merged
5 tasks
@vezenovm
chore: Update Acvm 0.13.0 branch (#1465)
e0ecfb1 
have acvm-backend-bberg patch reference new branch with additional crate-type
kevaundray
kevaundray reviewed Jun 1, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
kevaundray
kevaundray reviewed Jun 1, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
kevaundray and others added 4 commits June 1, 2023 12:55
@kevaundray
Update Cargo.toml
fabc8b3
@kevaundray
Update Cargo.toml
e3aa026
@kevaundray
update flake.lock
a2defce
@guipublic
feat!: var message size for keccak in stdlib (#1481)
9ed1068 
* Var message size for keccak in stdlib

* fix the build:
remove aes blackbox
add domain separator for pedersen

* pedersen with domain separator
@vezenovm vezenovm changed the title chore: update to ACVM 0.13.0 chore!: update to ACVM 0.13.0 Jun 1, 2023
@kevaundray kevaundray marked this pull request as ready for review June 1, 2023 19:35
@vezenovm vezenovm added this pull request to the merge queue Jun 1, 2023
Merged via the queue into master with commit 22dee75 Jun 1, 2023
@vezenovm vezenovm deleted the acvm-0.13.0 branch June 1, 2023 23:52
@kevaundray kevaundray mentioned this pull request Jun 1, 2023
Closed
This was referenced Jun 2, 2023
Closed
Closed
Closed
@kevaundray kevaundray mentioned this pull request Jun 16, 2023
Merged
@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Jul 10, 2023 •
edited
Loading

@TomAFrench thanks for helping with documenting this PR!

compute_merkle_root is no longer implemented as a black box function (but still exists in stdlib)

We don't currently mention is compute_merkle_root a black box function or written in Noir in our docs:
https://noir-lang.org/dev/standard_library/merkle_trees

Anything that you'd like to add to the docs in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TomAFrench @Savio-Sou @kevaundray @vezenovm @phated @sirasistant @guipublic