Array equality

[joss-aztec]

Problem

Array equality isn't implemented in the ssa refactor's acir gen. Currently binary ops only support numerics, and not arrays.

Happy Case

The following program should compile (taken from array_neq test):

// Simple example of checking where two arrays are different
fn main(a: [Field; 32], b: [Field; 32]) {
     assert(a != b);
}

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

[joss-aztec]

Also affects integration test 7

[joss-aztec]

And test named ecdsa_secp256k1

[joss-aztec]

Test named generics affected.

[joss-aztec]

Test named 8_integration affected.

[joss-aztec]

Affects test named global_consts

[joss-aztec]

7_function

[joss-aztec]

Also affects integration test 6

[joss-aztec]

strings

[joss-aztec]

struct_inputs

[jfecher]

I'd be in favor of replacing the array equality a1 == a2 in each of these tests with

fn array_eq<T, N>(a1: [T; N], a2: [T; N], elem_eq: fn(T, T) -> bool) -> bool {
    let mut result = true;
    for i in 0 .. a1.len() {
        result &= elem_eq(a1[i], a2[i]);
    }
    result
}

Supporting == for all [T; N] regardless of T as we have now is a type soundness issue anyway.

[joss-aztec]

Affects test named keccak256

[joss-aztec]

Affects sha256