Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): Fix flatten_cfg for ifs with no else #1671

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix(ssa refactor): Fix flatten_cfg for ifs with no else #1671

merged 2 commits into from
Jun 13, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 13, 2023

Description

Problem*

Resolves #1420

Summary*

Adds a small check to flatten_cfg to avoid inlining a branch if the branch start matches the branch end.

Example

Before:

After:

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from joss-aztec June 13, 2023 16:58
@jfecher jfecher mentioned this pull request Jun 13, 2023
Merged
5 tasks
joss-aztec
joss-aztec approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joss-aztec joss-aztec added this pull request to the merge queue Jun 13, 2023
Merged via the queue into master with commit 7ce8cce Jun 13, 2023
@joss-aztec joss-aztec deleted the jf/fix-flatten-if-with-no-else branch June 13, 2023 19:28
This was referenced Jun 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joss-aztec joss-aztec joss-aztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated code with --experimental-ssa flattening pass
2 participants
@jfecher @joss-aztec