Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssa refactor): Change the result of simplifying Eq and Lt to bool #1672

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 13, 2023

Description

Problem*

This was a small issue I saw while testing main_bool_arg where when an Eq or Lt are simplified from known constants, the result was the operand type rather than bool. This later prevented optimizing the not instruction afterward.

Summary*

This PR sets out to

Example

Before:


After:


Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from joss-aztec June 13, 2023 16:59
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joss-aztec joss-aztec added this pull request to the merge queue Jun 13, 2023
Merged via the queue into master with commit 1d48929 Jun 13, 2023
@joss-aztec joss-aztec deleted the jf/ssa-eq-opt-type branch June 13, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants